httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: Appropriate patches for 2.2.19 and 2.0.64?
Date Sat, 03 Sep 2011 21:29:25 GMT
On 03.09.2011 21:49, Jeff Trawick wrote:
> On Wed, Aug 31, 2011 at 9:51 PM, William A. Rowe Jr.
> <wrowe@rowe-clan.net> wrote:
>> On 8/31/2011 4:16 PM, William A. Rowe Jr. wrote:
>>> I've attempted to simply substitute the 2.2.19 filter code into the
>>> 2.0.64 http_protocol.c sources, and am unsure how far off these patches
>>> are from what they need to be; there's been a significant amount of drift
>>> and refactoring in the interim.
>>
>> Still looking for feedback, but the attached applies and corresponds to
>> 2.2.20 with the exception of atoi rather than strtoi semantics, and without
>> the no DefaultType exception..
> 
> Here's some more feedback :)  The commented-out line below in the
> middle of your patch is borked, as the variable range has been moved
> through the string being parsed by ap_getword().  cur is what we're
> parsing this time through the loop, reflected in my minor
> modification (the next line).

...

> With this fix, I get no testcase failures and this skippage:
> 
> t/apache/byterange.t ........ ok
> t/apache/byterange2.t ....... ok
> t/apache/byterange3.t ....... skipped: (no reason given)
> t/apache/byterange4.t ....... ok
> t/apache/byterange5.t ....... ok
> t/apache/byterange6.t ....... skipped: apache version 2.3.15 or higher
> is required, this is version 2.0.65
> t/apache/byterange7.t ....... ok

Same here, at least no more failures for Range related tests using the
updated patch.

> Thanks for putting this together so that there was something to try out!!!!

+1

Rainer

Mime
View raw message