httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r1163918 - /httpd/httpd/trunk/modules/http/byterange_filter.c
Date Thu, 01 Sep 2011 16:37:46 GMT
On 9/1/2011 1:30 AM, rpluem@apache.org wrote:
> Author: rpluem
> Date: Thu Sep  1 06:30:02 2011
> New Revision: 1163918
> 
> URL: http://svn.apache.org/viewvc?rev=1163918&view=rev
> Log:
> * Fix error message

> --- httpd/httpd/trunk/modules/http/byterange_filter.c (original)
> +++ httpd/httpd/trunk/modules/http/byterange_filter.c Thu Sep  1 06:30:02 2011
> @@ -640,7 +640,9 @@ static int ap_set_byterange(request_rec 
>      }
>      else if (num_ranges == 0 && unsatisfiable) {
>          /* If all ranges are unsatisfiable, we should return 416 */
> -        	ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, "0U");
> +        ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r,
> +                      "All ranges in Range header (%s) are unsatisfiable",
> +                      it);

I know this isn't your change, but just noticed it.  APLOG_ERR?
At its highest shouldn't that be APLOG_INFO?

APLOG_ERR and APLOG_WARN should be reserved for server-side errors
that we have some control over, not bogus input :)

Mime
View raw message