Return-Path: X-Original-To: apmail-httpd-dev-archive@www.apache.org Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8B78B7063 for ; Mon, 29 Aug 2011 15:03:29 +0000 (UTC) Received: (qmail 50471 invoked by uid 500); 29 Aug 2011 15:03:28 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 50392 invoked by uid 500); 29 Aug 2011 15:03:28 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 50378 invoked by uid 99); 29 Aug 2011 15:03:27 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Aug 2011 15:03:27 +0000 X-ASF-Spam-Status: No, hits=0.7 required=5.0 tests=RCVD_IN_DNSWL_NONE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: 76.96.30.80 is neither permitted nor denied by domain of jim@jagunet.com) Received: from [76.96.30.80] (HELO qmta08.emeryville.ca.mail.comcast.net) (76.96.30.80) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Aug 2011 15:03:19 +0000 Received: from omta18.emeryville.ca.mail.comcast.net ([76.96.30.74]) by qmta08.emeryville.ca.mail.comcast.net with comcast id SEmw1h0061bwxycA8F2u4z; Mon, 29 Aug 2011 15:02:54 +0000 Received: from [192.168.199.10] ([69.251.84.64]) by omta18.emeryville.ca.mail.comcast.net with comcast id SF631h00g1PGofZ8eF64sq; Mon, 29 Aug 2011 15:06:04 +0000 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Apple Message framework v1244.3) Subject: Re: svn commit: r1162579 - /httpd/httpd/trunk/modules/http/byterange_filter.c From: Jim Jagielski In-Reply-To: Date: Mon, 29 Aug 2011 11:02:56 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20110828194521.B316C238888F@eris.apache.org> <201108290944.51383.sf@sfritsch.de> To: dev@httpd.apache.org X-Mailer: Apple Mail (2.1244.3) On Aug 29, 2011, at 5:06 AM, Pl=FCm, R=FCdiger, VF-Group wrote: >=20 >=20 >> -----Original Message----- >> From: Stefan Fritsch [mailto:sf@sfritsch.de]=20 >> Sent: Montag, 29. August 2011 09:45 >> To: dev@httpd.apache.org >> Subject: Re: svn commit: r1162579 -=20 >> /httpd/httpd/trunk/modules/http/byterange_filter.c >>=20 >> On Sunday 28 August 2011, Stefan Fritsch wrote: >>=20 >>> This is broken. It causes the Content-Length header to contain the >>> size of the original file instead of the response body. Is the >>> correct fix to add apr_table_unset(r->headers_out, >>> "Content-Length") ? >>=20 >> Committed that to trunk and updated=20 >> http://people.apache.org/~sf/byterange-no-merge.2.2.diff to=20 >> include it=20 >> and a change to reset the status to 200 if the range header is=20 >> invalid. The latter issue was fixed in trunk by Eric's MaxRanges=20 >> change. >>=20 >=20 > Patch looks good, but a few comments: >=20 > 1. r1162669 is missing (provided this was really a good idea from me = :-)). > 2. I adjusted trunk code to drop the copying of the original range > header to "or" as well as this does not seem to be needed = (r1162687). >=20 +1 on the diff-file with those 2 changes=85 Will commit in 1.5 hrs unless I hear vetoes and will then push on for a T&R