Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: local policy)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: svn commit: r1162579 -
 /httpd/httpd/trunk/modules/http/byterange_filter.c
Date: Mon, 29 Aug 2011 11:06:33 +0200
Message-ID: 
 <E563FB5AB3F02844AC749BA39E494AB4053BBC2F@VF-MBX11.internal.vodafone.com>
In-Reply-To: <201108290944.51383.sf@sfritsch.de>
Thread-Topic: svn commit: r1162579 -
 /httpd/httpd/trunk/modules/http/byterange_filter.c
Thread-Index: AcxmH6rYbyFb+ZXnRH6k5JkO5GBhPgACknWQ
References: <20110828194521.B316C238888F@eris.apache.org>
 <alpine.DEB.2.00.1108282333370.3518@eru.sfritsch.de>
 <201108290944.51383.sf@sfritsch.de>
From: =?iso-8859-1?Q?=22Pl=FCm=2C_R=FCdiger=2C_VF-Group=22?=
 <ruediger.pluem@vodafone.com>
To: <dev@httpd.apache.org>

=20

> -----Original Message-----
> From: Stefan Fritsch [mailto:sf@sfritsch.de]=20
> Sent: Montag, 29. August 2011 09:45
> To: dev@httpd.apache.org
> Subject: Re: svn commit: r1162579 -=20
> /httpd/httpd/trunk/modules/http/byterange_filter.c
>=20
> On Sunday 28 August 2011, Stefan Fritsch wrote:
>=20
> > This is broken. It causes the Content-Length header to contain the
> > size of the original file instead of the response body. Is the
> > correct fix to add apr_table_unset(r->headers_out,
> > "Content-Length") ?
>=20
> Committed that to trunk and updated=20
> http://people.apache.org/~sf/byterange-no-merge.2.2.diff to=20
> include it=20
> and a change to reset the status to 200 if the range header is=20
> invalid. The latter issue was fixed in trunk by Eric's MaxRanges=20
> change.
>=20

Patch looks good, but a few comments:

1. r1162669 is missing (provided this was really a good idea from me =
:-)).
2. I adjusted trunk code to drop the copying of the original range
   header to "or" as well as this does not seem to be needed (r1162687).

Regards

R=FCdiger