Return-Path: X-Original-To: apmail-httpd-dev-archive@www.apache.org Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B28E77354 for ; Mon, 29 Aug 2011 08:41:25 +0000 (UTC) Received: (qmail 77389 invoked by uid 500); 29 Aug 2011 08:41:25 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 76649 invoked by uid 500); 29 Aug 2011 08:41:19 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 76036 invoked by uid 99); 29 Aug 2011 08:41:07 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Aug 2011 08:41:07 +0000 X-ASF-Spam-Status: No, hits=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [195.232.224.73] (HELO mailout04.vodafone.com) (195.232.224.73) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Aug 2011 08:40:57 +0000 Received: from mailint04 (localhost [127.0.0.1]) by mailout04 (Postfix) with ESMTP id 59DB01327C2 for ; Mon, 29 Aug 2011 10:40:36 +0200 (CEST) Received: from avoexs01.internal.vodafone.com (unknown [145.230.4.134]) by mailint04 (Postfix) with ESMTP id 4D5CC1327D3 for ; Mon, 29 Aug 2011 10:40:36 +0200 (CEST) Received: from VF-MBX11.internal.vodafone.com ([145.230.5.20]) by avoexs01.internal.vodafone.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 29 Aug 2011 10:40:37 +0200 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: svn commit: r1162579 - /httpd/httpd/trunk/modules/http/byterange_filter.c Date: Mon, 29 Aug 2011 10:40:34 +0200 Message-ID: In-Reply-To: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: svn commit: r1162579 - /httpd/httpd/trunk/modules/http/byterange_filter.c Thread-Index: AcxlyojF5e8hOjieTHG/5xkRWd36/gAW4lfg References: <20110828194521.B316C238888F@eris.apache.org> From: =?iso-8859-1?Q?=22Pl=FCm=2C_R=FCdiger=2C_VF-Group=22?= To: X-OriginalArrivalTime: 29 Aug 2011 08:40:37.0586 (UTC) FILETIME=[53661B20:01CC6627] X-Virus-Checked: Checked by ClamAV on apache.org =20 > -----Original Message----- > From: Stefan Fritsch [mailto:sf@sfritsch.de]=20 > Sent: Sonntag, 28. August 2011 23:36 > To: dev@httpd.apache.org > Subject: Re: svn commit: r1162579 -=20 > /httpd/httpd/trunk/modules/http/byterange_filter.c >=20 > On Sun, 28 Aug 2011, sf@apache.org wrote: >=20 > > Author: sf > > Date: Sun Aug 28 19:45:21 2011 > > New Revision: 1162579 > > > > URL: http://svn.apache.org/viewvc?rev=3D1162579&view=3Drev > > Log: > > Every 32 ranges, pass the prepared ranges down the filter chain. > > > > Modified: > > httpd/httpd/trunk/modules/http/byterange_filter.c > > > > Modified: httpd/httpd/trunk/modules/http/byterange_filter.c > > URL:=20 > http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http/by > terange_filter.c?rev=3D1162579&r1=3D1162578&r2=3D1162579&view=3Ddiff > >=20 > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > --- httpd/httpd/trunk/modules/http/byterange_filter.c (original) > > +++ httpd/httpd/trunk/modules/http/byterange_filter.c Sun=20 > Aug 28 19:45:21 2011 > > @@ -378,6 +378,12 @@ AP_CORE_DECLARE_NONSTD(apr_status_t) ap_ > > } > > > > APR_BRIGADE_CONCAT(bsend, tmpbb); > > + if (i && i % 32 =3D=3D 0) { > > + /* Every now and then, pass what we have down=20 > the filter chain */ > > + if ((rv =3D ap_pass_brigade(f->next, bsend)) !=3D=20 > APR_SUCCESS) > > + return rv; > > + apr_brigade_cleanup(bsend); > > + } > > } >=20 > This is broken. It causes the Content-Length header to=20 > contain the size of=20 > the original file instead of the response body. Is the=20 > correct fix to add > apr_table_unset(r->headers_out, "Content-Length") ? This looks correct. Maybe to be extra save we should also set r->clength = to 0 as well. Regards R=FCdiger