httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Plüm, Rüdiger, VF-Group" <ruediger.pl...@vodafone.com>
Subject RE: svn commit: r1162579 - /httpd/httpd/trunk/modules/http/byterange_filter.c
Date Mon, 29 Aug 2011 09:06:33 GMT
 

> -----Original Message-----
> From: Stefan Fritsch [mailto:sf@sfritsch.de] 
> Sent: Montag, 29. August 2011 09:45
> To: dev@httpd.apache.org
> Subject: Re: svn commit: r1162579 - 
> /httpd/httpd/trunk/modules/http/byterange_filter.c
> 
> On Sunday 28 August 2011, Stefan Fritsch wrote:
> 
> > This is broken. It causes the Content-Length header to contain the
> > size of the original file instead of the response body. Is the
> > correct fix to add apr_table_unset(r->headers_out,
> > "Content-Length") ?
> 
> Committed that to trunk and updated 
> http://people.apache.org/~sf/byterange-no-merge.2.2.diff to 
> include it 
> and a change to reset the status to 200 if the range header is 
> invalid. The latter issue was fixed in trunk by Eric's MaxRanges 
> change.
> 

Patch looks good, but a few comments:

1. r1162669 is missing (provided this was really a good idea from me :-)).
2. I adjusted trunk code to drop the copying of the original range
   header to "or" as well as this does not seem to be needed (r1162687).

Regards

Rüdiger

Mime
View raw message