httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Plüm, Rüdiger, VF-Group" <ruediger.pl...@vodafone.com>
Subject RE: svn commit: r1161791 - /httpd/httpd/trunk/modules/http/byterange_filter.c
Date Fri, 26 Aug 2011 15:02:23 GMT
I guess this should catch cases where you have overlapping or adjacent ranges next to each
other but in the wrong order,
so e.g.
 
2000-3000,1000-2000
 
or
 
2000-3000,1500-2500
 
But I think this check is currently wrong as you point out. Currently not sure how to fix
it.
 
Regards
 
Rüdiger


________________________________

	From: Greg Ames [mailto:ames.greg@gmail.com] 
	Sent: Freitag, 26. August 2011 16:58
	To: dev@httpd.apache.org
	Subject: Re: svn commit: r1161791 - /httpd/httpd/trunk/modules/http/byterange_filter.c
	
	


	On Thu, Aug 25, 2011 at 7:02 PM, <sf@apache.org> wrote:
	


		+            if (!(ranges[i].start > ranges[i-1].end   + 1 &&
		+                  ranges[i].end   < ranges[i-1].start - 1))
		
		

	and the if condition looks similar.  the first test is fine, but why is ranges[i].end <
ranges[i-1].start a good thing?  since we have the ! in front, we are testing for the normal
ascending case.
	
	Greg 
	



Mime
View raw message