httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Plüm, Rüdiger, VF-Group" <ruediger.pl...@vodafone.com>
Subject RE: With IP address in Host: header ServerName/ServerAlias doesn't work
Date Tue, 23 Aug 2011 10:25:14 GMT
 

> -----Original Message-----
> From: Micha Lenk [mailto:micha@lenk.info] 
> Sent: Dienstag, 23. August 2011 12:08
> To: dev@httpd.apache.org
> Subject: Re: With IP address in Host: header 
> ServerName/ServerAlias doesn't work
> 
> Hi,
> 
> On 08/23/2011 10:42 AM CEST +02:00, Micha Lenk wrote:
> > However, I believe the fix is yet incomplete. The function
> > ap_matches_request_vhost() used by modules like mod_proxy seems to
> > implement the virtual host check also in the wrong order. [...]
> > 
> > I'll follow up with a patch for this function later.
> 
> Here you go. Attached is the suggested patch for the function
> ap_matches_request_vhost().
> 
> Anything else missing?

IMHO the patch does not solve the issue mentioned in the comment
and is not needed.
Keep in mind the difference between ap_matches_request_vhost and
check_host_alias:

ap_matches_request_vhost checks only the data of *one* server_rec
and hence only *one* Servername and ServerAlias settings as set for
this vhost, whereas check_host_alias scans over *multiple* server_recs
with *multiple* Servername and ServerAlias settings from different vhosts.

Regards

Rüdiger

 

Mime
View raw message