httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe Jr." <>
Subject Re: svn commit: r1161681 - /httpd/httpd/trunk/modules/http/byterange_filter.c
Date Fri, 26 Aug 2011 16:11:55 GMT
On 8/26/2011 6:42 AM, Jim Jagielski wrote:
> IMO, the function of ap_set_byterange() is to create the
> official working copy of r->range that will be used, and in doing
> so, provide first level verification of what is valid
> (as well as determining if we want to accept the byte-range
> as provided by the client or simply bail out with a 416
> or 200).

Certainly, but we can do so through an array, and can much more quickly
reassemble the canonical r->range from that array.  Only two string ops
(decode, and then format).  Once we have an untainted r->range, this is
what we aught to pass on to any back end proxy client.

> If we are going to fix it, imo, we should do it here, but
> I'm +-0 on whether to ignore or break when we hit a wrong
> order…

Not break; the spec is blindingly clear that a 200 is always a right
answer, so if we inhibit rewinding, we should fall back on 200 if
any range could be satisfied.  (If the content is shorter than any
of the given ranges, we can 416).  No?

View raw message