httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: svn commit: r1142264 - /httpd/httpd/trunk/server/mpm/winnt/child.c
Date Sat, 02 Jul 2011 19:02:21 GMT
On Sat, Jul 2, 2011 at 2:56 PM, Jeff Trawick <trawick@gmail.com> wrote:
> I'm checking for the same bug elsewhere in r1103595...

strangely enough, I properly initialized the apr_thread_t pointer to
NULL in the two MPMs I didn't test (OS/2 and NetWare)

>
> On Sat, Jul 2, 2011 at 2:53 PM,  <trawick@apache.org> wrote:
>> Author: trawick
>> Date: Sat Jul  2 18:53:29 2011
>> New Revision: 1142264
>>
>> URL: http://svn.apache.org/viewvc?rev=1142264&view=rev
>> Log:
>> Initialize apr_thread_t pointer to NULL so that apr_os_thread_put()
>> allocates a new one.  This resolves a crash seen on WinXP, caused
>> by r1103595.
>>
>> Bad revision found by: Gregg L Smith <gls gknw.net>
>>
>> Modified:
>>    httpd/httpd/trunk/server/mpm/winnt/child.c
>>
>> Modified: httpd/httpd/trunk/server/mpm/winnt/child.c
>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/mpm/winnt/child.c?rev=1142264&r1=1142263&r2=1142264&view=diff
>> ==============================================================================
>> --- httpd/httpd/trunk/server/mpm/winnt/child.c (original)
>> +++ httpd/httpd/trunk/server/mpm/winnt/child.c Sat Jul  2 18:53:29 2011
>> @@ -728,7 +728,7 @@ static winnt_conn_ctx_t *winnt_get_conne
>>  */
>>  static DWORD __stdcall worker_main(void *thread_num_val)
>>  {
>> -    apr_thread_t *thd;
>> +    apr_thread_t *thd = NULL;
>>     apr_os_thread_t osthd;
>>     static int requests_this_child = 0;
>>     winnt_conn_ctx_t *context = NULL;

Mime
View raw message