httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe Jr." <wr...@rowe-clan.net>
Subject Re: Windows Laundry List pt3, mod_watchdog
Date Sun, 03 Jul 2011 17:40:21 GMT
On 7/1/2011 12:26 AM, Mladen Turk wrote:
> On 07/01/2011 06:31 AM, Gregg L. Smith wrote:
>> Hi folks,
>>
>> Well, this is the same chunk of Win32 specific debugging code causing this module
to
>> crash yet again. I remember suggesting it be removed before, now I am a little more
>> adamant about it because it is really not needed, IMO of course. If you really got
to
>> have it there, please&&  a
>> _DEBUG to the #ifdef WIN32.
>> This module is needed for heartmonitor (which has it's own problems coming under
>> separate cover). So, either it crashes on win32 or it works, your choice :-) If your
>> choice is let it fail, then get rid of it all, heartbeat, heartmonitor,
>> lb_method_heartmonitor&  watchdog on Windoze. Of course, if there is no improvement
on
>> documentation, most of it will go bye bye come GA anyway, per what is stated in STATUS.
>> Attached patch just gets rid of it.
>>
> 
> This cannot be omitted.
> Getting the parent pid means we we are in the child process, so we must not
> init the parent watchdog thread (see 'return OK;')

That's not how to detect it, you break -X mode.

There is an ap_mpm_query to determine if this is the child.

Mime
View raw message