httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Kew <>
Subject Re: [PATCH 51489] ProxyPassReverse issue + patch
Date Sat, 09 Jul 2011 09:16:29 GMT

On 8 Jul 2011, at 17:29, Micha Lenk wrote:

> Hi Apache developers,
> I'm using Apache as a reverse proxy in a simple load balancer setup.
> I use ProxyPassReverse in order to re-write the backend server name in HTTP redirections
(ie. in the Location header of the HTTP response).
> My configuration for the virtual host essentially looks like this:
> <Proxy balancer://196f045aca6adc82a0b6eea93ed286a1>
> 	BalancerMember http://server-1.local status=-SE
> 	BalancerMember http://server-2.local status=-SE
> </Proxy>

Is the absence of slashes after local there intentional?  You have a
slash in your ProxyPass[Reverse] directives.

> What I bother about is the additional slash before '/foo/', so I digged into the source
code and found the following lines in modules/proxy/proxy_util.c:

That's not easy to follow: your comments don't cross-reference to the code
until I've opened a lot more windows than I have screen space for.
A link to your bugzilla report would've helped, and your reference to
source is ambiguous - I guessed /trunk/.

When digging in source for this kind of thing, the "annotate" feature of svn
is your best tool:
The lines you're unhappy about were introduced in r771587:
which has quite an informative commit message.  Maybe that might help
to figure out the purpose?

I confess in this case I too am at a loss to see the purpose of that test.
Well, we do need to normalise the case of a missing URL, but that test appears
to be doing it the wrong way and making a special case of a normal one.

Nick Kew

Available for work, contract or permanent

View raw message