httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Fritsch ...@sfritsch.de>
Subject Re: svn commit: r1032002 - in /httpd/httpd/trunk: CHANGES STATUS modules/http/config.m4 modules/http/config2.m4 server/main.c
Date Sun, 12 Jun 2011 10:10:29 GMT
On Fri, 10 Jun 2011, Jeff Trawick wrote:
>> Fix hook sorting for the pre_config hook.
>> Move modules/http/config2.m4 back to modules/http/config.m4, since this was
>> only done as work-around in r88887 for the broken hook-sorting.

> In consideration of backporting:
>
> Calling apr_hook_sort_all() earlier affects only the pre-config hook
> and seems unlikely to break a fragile third-party module.
>
> The config*m4 rename potentially affects any hook that http_core
> implements, but it just moves it around within the list of static
> modules, and fragile third-party code isn't often built statically.
>
> I don't expect either part of this to be disruptive to 2.2.x but the
> main.c is the only necessary part of the fix, and doing only that
> results in  a little less risk of breaking fragile third-party code.
>
> Thoughts/corrections?

+1 to backporting, and I also agree that the config*m4 rename is not 
necessary and should be left out.

Mime
View raw message