httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: svn commit: r1082196 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/core.xml include/ap_mmn.h include/http_core.h include/httpd.h server/core.c server/request.c server/util.c
Date Wed, 18 May 2011 23:06:08 GMT
On Wed, May 18, 2011 at 4:51 PM, William A. Rowe Jr.
<wrowe@rowe-clan.net> wrote:
> On 5/18/2011 1:53 PM, Eric Covener wrote:
>> emails crossed and I got a 15-minute conference call reprieve.  w/
>> minor MMN bump:
>>
>> http://people.apache.org/~covener/patches/httpd-2.2.x-fix_keep2f-2.diff
>
>   return ap_unescape_url_keep2f_ex(url,1);  could be better formatted
> (consistent indentation and space between args), and note my other comment
> on wordsmithing the ap_mmn file.
>
> otherwise +1 from me for this to be committed to 2.2.x branch.

same comment from me on the spacing
needs something like "BROKEN ABI -- fixed in 2.2.19" instead of "superceded"

otherwise +1

Mime
View raw message