httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jus...@erenkrantz.com>
Subject Re: svn commit: r1103315 - /httpd/httpd/trunk/modules/filters/mod_deflate.c
Date Mon, 23 May 2011 15:57:59 GMT
On Mon, May 23, 2011 at 4:54 AM, Ruediger Pluem <rpluem@apache.org> wrote:
> Hm, why is it not sufficient that we call ap_remove_output_filter and remove the
> filter from the chain if we do not initialize?
> Does ap_remove_output_filter not remove the filter when it is the first one
> in the chain?

mod_dav uses r->output_filters - but, the pointer never gets updated
when it is the first one in the chain.  Hence, we call mod_deflate all
the time even on a request that can't support it - so we have to avoid
repeated memory allocations in that case.  -- justin

Mime
View raw message