httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: Universal setting for APR_HOOK_PROBES_ENABLED
Date Tue, 10 May 2011 11:52:44 GMT

On May 9, 2011, at 5:06 PM, Jeff Trawick wrote:
> 
> This patch disables hook probes for our two hooks which don't have args:
> 

>         /* which gen? */
> 
> ugly but effective
> 

+1 (on both counts ;)


> 
> I rehashed that with the latest code and the ugly no-arg-hook patch
> above.  Attached is a .c file implementation and a corresponding
> ap_hook_probes.h for this sample feature set.  The .c file has to be
> included from some httpd source file to get it linked in.  It won't
> work without the workaround for our two no-arg hooks.
> 
> What's a cleaner way to add the code to the server, assuming that
> somebody implementing hook probes needs to add
> 
> 1) a .h file that gets included by ap_hooks.h
> 2) a .c file that should be linked in to httpd
> 
> ?
> 
> Maybe --enable-hook-probes=/path/to/ap_hook_probes.{c,h}
> 
> Alternately, the code that needs to get linked in could be implemented
> with a drop-in modules/myprobes/{config.m4,mod_myprobes.c,etc.} and
> then --enable the module statically.
> <hook_probe_impl.c><ap_hook_probes.h>

My thoughts are to hopefully make it as self-contained w/i a
module as possible... That is, the dev must enable-hook-probes and
then enable/link-in a module which implements them, so I'm
more consdering the latter.

Mime
View raw message