httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r1129914 - in /httpd/httpd/trunk/modules/core: mod_watchdog.c mod_watchdog.h
Date Tue, 31 May 2011 23:15:23 GMT
On 5/31/2011 4:05 PM, Jeff Trawick wrote:
> On Tue, May 31, 2011 at 4:55 PM,  <wrowe@apache.org> wrote:
>> Author: wrowe
>> Date: Tue May 31 20:55:02 2011
>> New Revision: 1129914
>>
>> URL: http://svn.apache.org/viewvc?rev=1129914&view=rev
>> Log:
>> solve getpid() process.h function order
>>
>> Modified:
>>    httpd/httpd/trunk/modules/core/mod_watchdog.c
>>    httpd/httpd/trunk/modules/core/mod_watchdog.h
>>
>> Modified: httpd/httpd/trunk/modules/core/mod_watchdog.c
>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/core/mod_watchdog.c?rev=1129914&r1=1129913&r2=1129914&view=diff
>> ==============================================================================
>> --- httpd/httpd/trunk/modules/core/mod_watchdog.c (original)
>> +++ httpd/httpd/trunk/modules/core/mod_watchdog.c Tue May 31 20:55:02 2011
>> @@ -17,6 +17,14 @@
>>  /* Watchdog module.
>>  */
>>
>> +#include "apr.h"
>> +#if APR_HAVE_UNISTD_H
>> +#include <unistd.h>         /* for getpid() */
>> +#endif
>> +#if APR_HAVE_PROCESS_H
> 
> I guess this is with apr 1.4, as I believe you deleted that feature in
> apr trunk ;)

I expect that's right.  Although mod_watchdog.h didn't need to pollute the
namespace of every consumer of mod_watchdog, so this patch should be ok
on either apr :)

Should we go ahead and drop in process.h unilaterally in apr.h.in/apr.hw
following windows.h?  WDYT?


Mime
View raw message