httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r1103315 - /httpd/httpd/trunk/modules/filters/mod_deflate.c
Date Tue, 24 May 2011 06:08:46 GMT


On 05/23/2011 06:11 PM, Justin Erenkrantz wrote:
> On Mon, May 23, 2011 at 6:00 AM, Graham Leggett <minfrin@sharp.fm> wrote:
>> On 23 May 2011, at 5:57 PM, Justin Erenkrantz wrote:
>>
>>> mod_dav uses r->output_filters - but, the pointer never gets updated
>>> when it is the first one in the chain.  Hence, we call mod_deflate all
>>> the time even on a request that can't support it - so we have to avoid
>>> repeated memory allocations in that case.  -- justin
>> This sounds like a general problem though, are other modules potentially
>> affected?
> 
> Yes - this why I said in my earlier post that we'd likely need to
> re-architect filters to deal with it.  -- justin
> 
> 

Indeed this sounds like a general problem, but
ap_remove_output_filter does adjust r->output_filters if f->r is set and the
filter is the first one in the chain.
Which responses exactly suffer from this behaviour?

Regards

RĂ¼diger

Mime
View raw message