httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r1103315 - /httpd/httpd/trunk/modules/filters/mod_deflate.c
Date Mon, 23 May 2011 14:54:58 GMT


On 05/15/2011 01:05 PM, jerenkrantz@apache.org wrote:
> Author: jerenkrantz
> Date: Sun May 15 11:05:36 2011
> New Revision: 1103315
> 
> URL: http://svn.apache.org/viewvc?rev=1103315&view=rev
> Log:
> Fix memory leak in mod_deflate.c when SetOutputFilter is enabled and DEFLATE
> is the first filter in the chain - this is seen with mod_dav + mod_deflate
> when the client can not do gzip and we constantly do the filter checks.
> 
> * modules/filters/mod_deflate.c
>   (deflate_ctx): Add a flag as to whether we are successfully initialized.
>   (deflate_out_filter): Always create filter ctx and set filter_init flag only
>   after we are successfully initialized.
> 
> Modified:
>     httpd/httpd/trunk/modules/filters/mod_deflate.c

Hm, why is it not sufficient that we call ap_remove_output_filter and remove the
filter from the chain if we do not initialize?
Does ap_remove_output_filter not remove the filter when it is the first one
in the chain?

Regards

RĂ¼diger


Mime
View raw message