Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 74263 invoked from network); 13 Apr 2011 02:03:07 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 13 Apr 2011 02:03:07 -0000 Received: (qmail 2711 invoked by uid 500); 13 Apr 2011 02:03:05 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 2657 invoked by uid 500); 13 Apr 2011 02:03:05 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 2649 invoked by uid 99); 13 Apr 2011 02:03:05 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Apr 2011 02:03:05 +0000 X-ASF-Spam-Status: No, hits=0.7 required=5.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [194.242.35.75] (HELO dns-factory.at) (194.242.35.75) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Apr 2011 02:02:59 +0000 Received: from [172.17.100.7] apache@gknw.net [84.63.69.233] by dns-factory.at with NetMail SMTP Agent $Revision: 8582 $ on Novell NetWare via secured & encrypted transport (TLS); Wed, 13 Apr 2011 04:02:13 +0200 Message-ID: <4DA50420.80404@apache.org> Date: Wed, 13 Apr 2011 04:02:08 +0200 From: Guenter Knauf User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.2.15) Gecko/20110303 Lightning/1.0b2 Thunderbird/3.1.9 MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: svn commit: r1086756 - in /httpd/httpd/trunk: docs/manual/developer/new_api_2_4.xml include/ap_mmn.h include/http_config.h modules/lua/mod_lua.c server/config.c server/util.c References: <20110329212935.2576723889B1@eris.apache.org> In-Reply-To: <20110329212935.2576723889B1@eris.apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Stefan, Am 29.03.2011 23:29, schrieb sf@apache.org: > Author: sf > Date: Tue Mar 29 21:29:34 2011 > New Revision: 1086756 > > URL: http://svn.apache.org/viewvc?rev=3D1086756&view=3Drev > Log: > Change the ap_cfg_getline() and ap_cfg_getc() to return an error code. > > Also: > - Make ap_cfg_getline() return APR_ENOSPC if a config line is too long.= > - Add ap_pcfg_strerror() function to convert ap_cfg_getline's return va= lue > into a nice message. > - Adjust definition of ap_configfile_t accordingly. > > Not bumping MMN because it has already been bumped today. > > Modified: > httpd/httpd/trunk/docs/manual/developer/new_api_2_4.xml > httpd/httpd/trunk/include/ap_mmn.h > httpd/httpd/trunk/include/http_config.h > httpd/httpd/trunk/modules/lua/mod_lua.c > httpd/httpd/trunk/server/config.c > httpd/httpd/trunk/server/util.c =2E.. > /* Read one character from a configfile_t */ > -AP_DECLARE(int) ap_cfg_getc(ap_configfile_t *cfp) > +AP_DECLARE(apr_status_t) ap_cfg_getc(char *ch, ap_configfile_t *cfp) =2E.. I'm not yet convinced that this API change is a good idea ... we have this API already since httpd 1.3 times: http://httpd.apache.org/dev/apidoc/apidoc_ap_cfg_getc.html and a couple of modules may rely on it ... I think we should only declare the original function as deprecated, and=20 add a new one, f.e.: AP_DECLARE(apr_status_t) ap_cfg_getchar(char *ch, ap_configfile_t *cfp) G=C3=BCn.