httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: svn commit: r1057048 - in /httpd/httpd/trunk: CHANGES modules/generators/mod_status.c
Date Wed, 27 Apr 2011 20:39:57 GMT
On Wed, Apr 27, 2011 at 12:27 PM, Jim Jagielski <jim@jagunet.com> wrote:
> How does this affect the XML output (sorry, can't test
> here)? Personally, I'm sure there are scripts that take
> the output from server-status and parse it, and specifically
> look for '.'... this will break those.
>
> (PS: Sorry if I'm missing out on the context of this
>     change...)

You mean the short form ("/server-status?auto")?

Before this a.m.'s tweak, there would be blanks within the scoreboard
map (single line of K_.CRWetc.).  Now the blanks are suppressed.

>
> On Apr 26, 2011, at 3:57 PM, Jeff Trawick wrote:
>
>> On Sun, Jan 9, 2011 at 6:00 PM,  <sf@apache.org> wrote:
>>> Author: sf
>>> Date: Sun Jan  9 23:00:33 2011
>>> New Revision: 1057048
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1057048&view=rev
>>> Log:
>>> mod_status: Don't show slots which are disabled by MaxClients as open.
>>
>> They now get displayed as ' ' instead of '.'.
>>
>> No complaints here about not displaying unused slots as open, but the
>> result can look a bit odd.
>>
>> ---------cut here-----------
>> 1 requests currently being processed, 49 idle workers
>>
>> _________________________
>>                                    ______W__________________
>>
>>
>>
>> Scoreboard Key:
>> -----------cut here--------------
>>
>> On Windows, with huge default ThreadLimit relative to ThreadsPerChild,
>> you're left with lots of unexpected whitespace.
>>
>> What about just surpressing the ' ' when printing out the worker map?
>>
>> After a graceful restart which shrinks MaxClients or ThreadsPerChild
>> you might have the map gradually get smaller for a short time as
>> workers in those "beyond" scoreboard entries exit, but generally it
>> would look better.
>>
>> Comments?  (Do folks want the space used to reflect ThreadLimit * ServerLimit?)
>>
>>> Modified: httpd/httpd/trunk/modules/generators/mod_status.c
>>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/generators/mod_status.c?rev=1057048&r1=1057047&r2=1057048&view=diff
>>> ==============================================================================
>>> --- httpd/httpd/trunk/modules/generators/mod_status.c (original)
>>> +++ httpd/httpd/trunk/modules/generators/mod_status.c Sun Jan  9 23:00:33 2011
>>
>>> @@ -483,7 +492,8 @@ static int status_handler(request_rec *r
>>>         ap_rputs("\"<b><code>L</code></b>\" Logging,
\n", r);
>>>         ap_rputs("\"<b><code>G</code></b>\" Gracefully
finishing,<br /> \n", r);
>>>         ap_rputs("\"<b><code>I</code></b>\" Idle
cleanup of worker, \n", r);
>>> -        ap_rputs("\"<b><code>.</code></b>\" Open
slot with no current process</p>\n", r);
>>> +        ap_rputs("\"<b><code>.</code></b>\" Open
slot with no current process,<br />\n", r);
>>> +        ap_rputs("\"<b><code> </code></b>\" Slot
disabled by MaxClients setting</p>\n", r);
>>
>>  (and/or by ThreadsPerChild)
>>
>
>



-- 
Born in Roswell... married an alien...

Mime
View raw message