Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: domain of covener@gmail.com designates
 74.125.82.173 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=ASJxqExeVCQwT+y2lmVZ06O/e8Tz9OzIwTnlLhYHFSb3JKLupJevN/WLwR1WQmYYKg
         NqIAn/2x6+NEy3z6XHS0G5OgGUCi9BBi4gO/93ktrzlVAQSD/tE9beuwcAUjCtGwqyZw
         ScV/JIaNgt6QF+i3pZYO5p45uKuPAx1ZC4FX8=
MIME-Version: 1.0
In-Reply-To: <4D910805.5080205@rowe-clan.net>
References: <4D910805.5080205@rowe-clan.net>
Date: Mon, 28 Mar 2011 18:46:39 -0400
Message-ID: <AANLkTi=qTcbB5omrnWEsqUowL2OBFA5wO13SHWJyE1xs@mail.gmail.com>
Subject: Re: ldap unreleasable
From: Eric Covener <covener@gmail.com>
To: dev@httpd.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 28, 2011 at 6:13 PM, William A. Rowe Jr.
<wrowe@rowe-clan.net> wrote:
> /* LDAP cache state information */
> typedef struct util_ldap_state_t {
> ...
> =A0 =A0int connectionPoolTTL;
> } util_ldap_state_t;
>
>
> I'm continue to grow more worried that the state of ldap in httpd
> and in apr enjoys very little granularity, oversight, or quality...
>
> =A01. Hungarian? =A0Forgot to eat breakfast that day? =A0Out of bounds
> =A0 =A0per httpd style rules.
>
> =A02. int? =A0Really? =A0This is assigned an apr_interval_time_t in its
> =A0 =A0config code.
>
> Please review and fix the style violations, and ensure that timeouts
> are doing what they were meant to do.
>

Thanks for the review, blockers above in r1086432 (and bugfix in r1086433)

--=20
Eric Covener
covener@gmail.com