httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dan Poirier <>
Subject Re: Removing ap_old_write_filter
Date Fri, 25 Mar 2011 22:59:50 GMT
On Fri. 2011-03-25 at 05:30 PM EDT, Stefan Fritsch <> wrote:

> Are you sure that ap_fwrite does not buffer? It calls 
> apr_brigade_write(), which, according to the apr-util docs, should 
> only flush if "the brigade is full".

You are correct. I saw the definition of ap_fwrite:

#define ap_fwrite(f, bb, data, nbyte) \
        apr_brigade_write(bb, ap_filter_flush, f, data, nbyte)

and looking too quickly at apr_brigade_write's code, thought it always
flushed when a flush function was passed to it.

Thanks for the correction.


View raw message