httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: [PATCH] default_rel_runtimedir everywhere (Windows, NetWare)
Date Sun, 27 Mar 2011 23:54:15 GMT
On Sun, Mar 27, 2011 at 6:09 PM, William A. Rowe Jr.
<wrowe@rowe-clan.net> wrote:
> On 3/27/2011 10:30 AM, Jeff Trawick wrote:
>>
>> Concerns (such as better name for the new file)?
>
> Only one... please don't add #include logic, let Gunter and I wire up
> the auto-copy to ap_config_layout.h and we will truly be consistent.
>
> You can update the patch to assume that file always exists.  Let's keep
> the main .c code as absolutely consistent as possible with fewer per-arch
> variations.

ap_config.h now unconditionally includes ap_config_layout.h.

I renamed the two OS-specific, non-autoconf-build versions to
{win32,netware}_config_layout.h to make it obvious to lurkers that
they should not include this file as present in the os directory.

Mime
View raw message