httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Covener <cove...@gmail.com>
Subject Re: ldap unreleasable
Date Mon, 28 Mar 2011 22:46:39 GMT
On Mon, Mar 28, 2011 at 6:13 PM, William A. Rowe Jr.
<wrowe@rowe-clan.net> wrote:
> /* LDAP cache state information */
> typedef struct util_ldap_state_t {
> ...
>    int connectionPoolTTL;
> } util_ldap_state_t;
>
>
> I'm continue to grow more worried that the state of ldap in httpd
> and in apr enjoys very little granularity, oversight, or quality...
>
>  1. Hungarian?  Forgot to eat breakfast that day?  Out of bounds
>    per httpd style rules.
>
>  2. int?  Really?  This is assigned an apr_interval_time_t in its
>    config code.
>
> Please review and fix the style violations, and ensure that timeouts
> are doing what they were meant to do.
>

Thanks for the review, blockers above in r1086432 (and bugfix in r1086433)

-- 
Eric Covener
covener@gmail.com

Mime
View raw message