httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NormW <no...@gknw.net>
Subject Re: [PATCH] default_rel_runtimedir everywhere (Windows, NetWare)
Date Sun, 27 Mar 2011 21:30:51 GMT
On 28/03/2011 6:08 AM, Jeff Trawick wrote:
> On Sun, Mar 27, 2011 at 3:26 PM, NormW<normw@gknw.net>  wrote:
>> On 28/03/2011 1:30 AM, Jeff Trawick wrote:
>>>
>>> For autoconf-based builds, DEFAULT_REL_RUNTIMEDIR is defined by the
>>> layout machinery, which creates ap_config_layout.h.
>>>
>>> For non-autoconf-based builds, there is no equivalent to
>>> ap_config_layout.h.  Windows and NetWare MPMs define
>>> DEFAULT_REL_RUNTIMEDIR in mpm_layout.h, but that is local to the MPM.
>>> So no definition is visible to modules and other source files.  As a
>>> work-around, several common source files have created their own
>>> defaults when DEFAULT_REL_RUNTIMEDIR is not defined.
>>>
>>> The attached patch creates a new os_layout.h for non-autoconf-based
>>> builds (just Windows and NetWare) which defines
>>> DEFAULT_REL_RUNTIMEDIR.  The workarounds from the several common
>>> source files are removed.  Third-party modules can also depend on
>>> DEFAULT_REL_RUNTIMEDIR again.
>>>
>>> Concerns (such as better name for the new file)?
>>>
>>> No, I didn't test it :)  My Visual C++ Express setup for httpd is not
>>> workable at present.
>>>
>>> I will try to test the docgen stuff before I commit.
>>
>> Seems like the paperclip failed.
>
> (blush)
>
> now attached
Hi,
Patch applies without issue, compiles for NetWare without issue, loads 
on server without issue, socachedbm creates its files in .\logs as 
previous and server can deliver Apache manual with no problems; bottom 
line is 'change looks fine for NetWare'.
Norm


Mime
View raw message