httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe Jr." <wr...@rowe-clan.net>
Subject Re: VS2010 release builds of Apache/mod_perl crash on Vista/2008/Win7
Date Tue, 08 Feb 2011 20:19:15 GMT
On 2/8/2011 8:29 AM, Steve Hay wrote:
> +        int len = (int)strlen(newarr[arg]) + 1;
> +        *env = (char*)_malloc_dbg(len * sizeof(char), _CRT_BLOCK, __FILE__, __LINE__);
> +        strcpy_s(*env, len, newarr[arg]);

That's just sick ... It's inexcusable to use strcpy when len is already known :)

Very interesting observations, are you in a position to try this with the older
C compilers?  Interested to know if we can just apply this to all flavors without
any headaches.

Mime
View raw message