Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 75928 invoked from network); 2 Jan 2011 16:58:25 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 2 Jan 2011 16:58:25 -0000 Received: (qmail 2845 invoked by uid 500); 2 Jan 2011 16:58:24 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 2408 invoked by uid 500); 2 Jan 2011 16:58:22 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 2400 invoked by uid 99); 2 Jan 2011 16:58:21 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Jan 2011 16:58:21 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED,FREEMAIL_FROM,T_FRT_SLUT,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received: from [140.211.11.9] (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with SMTP; Sun, 02 Jan 2011 16:58:20 +0000 Received: (qmail 75896 invoked by uid 2161); 2 Jan 2011 16:58:00 -0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) by euler.heimnetz.de (Postfix) with ESMTP id 499C524097 for ; Sun, 2 Jan 2011 17:58:16 +0100 (CET) Message-ID: <4D20AEA8.8040900@gmx.de> Date: Sun, 02 Jan 2011 17:58:16 +0100 From: =?UTF-8?B?UsO8ZGlnZXIgUGzDvG0=?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.24) Gecko/20100301 SeaMonkey/1.1.19 MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: svn commit: r1054323 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_ssl.xml docs/manual/upgrading.xml modules/ssl/ssl_engine_config.c modules/ssl/ssl_engine_vars.c modules/ssl/ssl_private.h modules/ssl/ssl_util_ssl.c modules/ssl/ssl_util_ssl.h References: <20110101235625.0C77323888E7@eris.apache.org> In-Reply-To: <20110101235625.0C77323888E7@eris.apache.org> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 01/02/2011 12:56 AM, sf@apache.org wrote: > Author: sf > Date: Sat Jan 1 23:56:24 2011 > New Revision: 1054323 > > URL: http://svn.apache.org/viewvc?rev=1054323&view=rev > Log: > Change the format of the SSL_{CLIENT,SERVER}_{I,S}_DN variables > to be RFC 2253 compatible, convert non-ASCII characters to UTF8, and > escape other special characters with backslashes. The old format can > still be used with the LegacyDNStringFormat argument to SSLOptions. > > Modified: > httpd/httpd/trunk/CHANGES > httpd/httpd/trunk/docs/manual/mod/mod_ssl.xml > httpd/httpd/trunk/docs/manual/upgrading.xml > httpd/httpd/trunk/modules/ssl/ssl_engine_config.c > httpd/httpd/trunk/modules/ssl/ssl_engine_vars.c > httpd/httpd/trunk/modules/ssl/ssl_private.h > httpd/httpd/trunk/modules/ssl/ssl_util_ssl.c > httpd/httpd/trunk/modules/ssl/ssl_util_ssl.h > Modified: httpd/httpd/trunk/modules/ssl/ssl_util_ssl.c > URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/ssl/ssl_util_ssl.c?rev=1054323&r1=1054322&r2=1054323&view=diff > ============================================================================== > --- httpd/httpd/trunk/modules/ssl/ssl_util_ssl.c (original) > +++ httpd/httpd/trunk/modules/ssl/ssl_util_ssl.c Sat Jan 1 23:56:24 2011 > @@ -344,14 +344,32 @@ BOOL SSL_X509_getBC(X509 *cert, int *ca, > #endif > } > > +/* convert a NAME_ENTRY to UTF8 string */ > +char *SSL_X509_NAME_ENTRY_to_string(apr_pool_t *p, X509_NAME_ENTRY *xsne) > +{ > + char *result = NULL; > + BIO* bio; > + int len; > + > + if ((bio = BIO_new(BIO_s_mem())) == NULL) > + return NULL; > + ASN1_STRING_print_ex(bio, X509_NAME_ENTRY_get_data(xsne), > + ASN1_STRFLGS_ESC_CTRL|ASN1_STRFLGS_UTF8_CONVERT); > + len = BIO_pending(bio); > + result = apr_palloc(p, len+1); > + len = BIO_read(bio, result, len); > + result[len] = NUL; > + BIO_free(bio); > + ap_xlate_proto_from_ascii(value, len); Shouldn't that be ap_xlate_proto_from_ascii(result, len); instead? Regards Rüdiger