Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (nike.apache.org: domain of i.galic@brainsware.org
 designates 188.40.115.121 as permitted sender)
Date: Sun, 16 Jan 2011 23:14:15 +0000 (UTC)
From: =?utf-8?Q?Igor_Gali=C4=87?= <i.galic@brainsware.org>
To: dev@httpd.apache.org
Message-ID: <2012615194.8562.1295219655013.JavaMail.root@iris>
In-Reply-To: <208980037.8560.1295219638385.JavaMail.root@iris>
Subject: Re: [PATCH] Suggesting a new mod_proxy ProxyAddHeaders directive
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


----- "Vincent Deffontaines" <vincent@gryzor.com> wrote:

> Greetings,
>=20
> Following a small discussion on #httpd irc channel, about=20
> X-Forwarded-For, X-Forwarded-Host and X-Forwarded-Server.
> These headers are currently set or altered by mod_proxy_http whenever
> a reverse proxy request is handled.

I caught that discussion but the only patches on the topic I found
sent to dev@ seemed to solve a different problem...

> Using RequestHeader to unset these headers is unefficient, probably
> for=20
> order processing reasons. Even if it was possible, it would not be=20
> sufficient, since an administrator might want to pass already existing
> headers without altering them, rather than just unsetting them.
>=20
> Here is a small patch against trunk. This patch introduces the=20
> ProxyAddHeaders directive.
> If set to "On" (default), the current mod_proxy_http behavior is kept
> :=20
> X-Forwarded-* headers are set, or completed for the request sent to
> the=20
> backend server.
> If set to "Off", X-Forwarded-* headers are just passed as in the
> client=20
> request, if defined.
>=20
> I have included the documentation patch, unsure whether it should be=20
> commited separately ?

No, that is all fine.

> Please comment and correct me if needed.

The patch looks straight-forward enough and fine to me.
+1

> Vincent Deffontaines


i

--=20
Igor Gali=C4=87

Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/