httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Igor Galić <i.ga...@brainsware.org>
Subject Re: [PATCH] Suggesting a new mod_proxy ProxyAddHeaders directive
Date Sun, 16 Jan 2011 23:14:15 GMT

----- "Vincent Deffontaines" <vincent@gryzor.com> wrote:

> Greetings,
> 
> Following a small discussion on #httpd irc channel, about 
> X-Forwarded-For, X-Forwarded-Host and X-Forwarded-Server.
> These headers are currently set or altered by mod_proxy_http whenever
> a reverse proxy request is handled.

I caught that discussion but the only patches on the topic I found
sent to dev@ seemed to solve a different problem...

> Using RequestHeader to unset these headers is unefficient, probably
> for 
> order processing reasons. Even if it was possible, it would not be 
> sufficient, since an administrator might want to pass already existing
> headers without altering them, rather than just unsetting them.
> 
> Here is a small patch against trunk. This patch introduces the 
> ProxyAddHeaders directive.
> If set to "On" (default), the current mod_proxy_http behavior is kept
> : 
> X-Forwarded-* headers are set, or completed for the request sent to
> the 
> backend server.
> If set to "Off", X-Forwarded-* headers are just passed as in the
> client 
> request, if defined.
> 
> I have included the documentation patch, unsure whether it should be 
> commited separately ?

No, that is all fine.

> Please comment and correct me if needed.

The patch looks straight-forward enough and fine to me.
+1

> Vincent Deffontaines


i

-- 
Igor Galić

Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/

Mime
View raw message