httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Fritsch ...@sfritsch.de>
Subject Re: svn commit: r1055250 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_http.c modules/proxy/proxy_util.c
Date Mon, 10 Jan 2011 20:26:58 GMT
On Thursday 06 January 2011, Plüm, Rüdiger, VF-Group wrote:
> > >  {
> > >
> > > -    request_rec *rp = apr_pcalloc(r->pool, sizeof(*r));
> > > +    apr_pool_t *pool;
> > > +
> > > +    apr_pool_create(&pool, c->pool);
> > > +
> > > +    request_rec *rp = apr_pcalloc(pool, sizeof(*r));
> > >
> > >  
> >
> > 
> >
> > MSVC idiosyncrasy, you cannot declare rp after doing 
> > something, in this 
> > case "something" is calling apr_pool_create.
> 
> Fixed in r1055771.

BTW, gcc has -Wdeclaration-after-statement to catch these things. 
Should we add that to the default warnings enabled in maintainer mode?

Mime
View raw message