Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Message-ID: <4CF5BDE4.9090603@rowe-clan.net>
Date: Tue, 30 Nov 2010 21:15:48 -0600
From: "William A. Rowe Jr." <wrowe@rowe-clan.net>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US;
 rv:1.9.2.12) Gecko/20101027 Lightning/1.0b2 Thunderbird/3.1.6
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Re: logging patch bug
References: <4CB38729.7040404@rowe-clan.net>
 <201010122157.12486.sf@sfritsch.de> <4CB6289E.7090405@redfish-solutions.com>
In-Reply-To: <4CB6289E.7090405@redfish-solutions.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 10/13/2010 4:46 PM, Philip Prindeville wrote:
>  On 10/12/10 12:57 PM, Stefan Fritsch wrote:
>> On Monday 11 October 2010, William A. Rowe Jr. wrote:
>>> Why were ap_errorlog_format_item->min_loglevel and
>>> ap_errorlog_info->level declared with two different types?
>> ap_errorlog_info->level is -1 if no log level is available, i.e. when
>> logging per-request/per-conn info. However, ap_errorlog_format_item-
>>> min_loglevel always contains a genuine loglevel (which is>=0).
>> Therefore I have declared the former as signed int and the latter as
>> unsigned int.
>>
>> But the comparison (item->min_loglevel>  info->level) in log.c does
>> cause a warning with -Wextra, even if it is correct. What do you
>> suggest? Adding a cast or changing the declaration of min_loglevel to
>> signed int?
> 
> If they are only compared in one place, I'd use a cast.  Least churn, and it means that
> static analysis could still be used elsewhere to easily detect when out-of-range
> assignments are made to the latter.

In any case, this should be fixed before the tag, since it's been almost 2 mos here...

.\server\log.c(1020) : warning C4018: '>' : signed/unsigned mismatch