Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Message-ID: <4CF41F1D.3050301@apache.org>
Date: Mon, 29 Nov 2010 22:46:05 +0100
From: Guenter Knauf <fuankg@apache.org>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de;
 rv:1.9.2.12) Gecko/20101027 Lightning/1.0b2 Thunderbird/3.1.6
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: mod_ssl ssl_util_stapling.c warnings
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: quoted-printable

Hi Steve,
ssl_util_stapling.c issues warnings / breaks when compiled with OSSL=20
1.0.0; MSVC warns:
\modules\ssl\ssl_util_stapling.c(140) : warning C4133: '=3D' :=20
incompatible types - from 'struct stack_st_OPENSSL_STRING *' to 'struct=20
stack_st_STRING *'
C:\buildprep\httpd-2.3.x.10\modules\ssl\ssl_util_stapling.c(142) :=20
warning C4133: 'function' : incompatible types - from 'struct=20
stack_st_STRING *' to 'struct stack_st *'
C:\buildprep\httpd-2.3.x.10\modules\ssl\ssl_util_stapling.c(148) :=20
warning C4133: 'function' : incompatible types - from 'struct=20
stack_st_STRING *' to 'struct stack_st_OPENSSL_STRING *'

and my picky CodeWarrior breaks:
Compiling ssl_util_stapling.c
### mwccnlm Compiler:
#    File: ssl_util_stapling.c
# ----------------------------
#     140:      aia =3D X509_get1_ocsp(x);
#   Error:                             ^
#   illegal implicit conversion from 'struct stack_st_OPENSSL_STRING *' t=
o
#   'struct stack_st_STRING *'
### mwccnlm Compiler:
#     142:          cinf->uri =3D sk_STRING_pop(aia);
#   Error:                                       ^
#   illegal implicit conversion from 'struct stack_st_STRING *' to
#   'struct stack_st *'
### mwccnlm Compiler:
#     148:          X509_email_free(aia);
#   Error:                             ^
#   illegal implicit conversion from 'struct stack_st_STRING *' to
#   'struct stack_st_OPENSSL_STRING *'

Errors caused tool to abort.

I think that we had some similar already in the past, and you suggested=20
a change which was compatible with both 0.9.8 and 1.0.0 branches, but I=20
cant recall ...
Or do we need to cleanly solve this with some version-depent defines?

G=FCn.