Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (nike.apache.org: domain of nickgearls@gmail.com designates
 209.85.215.45 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:reply-to:user-agent:mime-version:to:subject
         :content-type:content-transfer-encoding;
        b=Lwj04afMQq1A1KSaPgY9MQfpN1+aewX/u9zVmwlUso5w2xot2VXNes2Dcf3eSQ/pLR
         q22J9ifLFHB6wl3kKPxjVEFmkk9jAQIPwCTe64CK4+IpTTOS24j48oinFNl7gEIZfqoB
         eD8wjYHDoIHxBVT5fDQzMVr0MM/s2lwM6/DCc=
Message-ID: <4CD68497.7050901@gmail.com>
Date: Sun, 07 Nov 2010 11:51:03 +0100
From: Nick Gearls <nickgearls@gmail.com>
Reply-To: nickgearls@gmail.com
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US;
 rv:1.9.2.12) Gecko/20101027 Thunderbird/3.1.6
MIME-Version: 1.0
To: Development Apache <dev@httpd.apache.org>
Subject: Re: mod_substitute tags parsing
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Actually, the problem is that apr_table_get(r->subprocess_env, a) always 
returns null.
I suppose that the problem lies in the request variable "r".
I am using f->r where f is the "ap_filter_t" given as parameter to 
do_pattmatch().
Should I use another one,


Thanks,

Nick


-------- Original Message --------
Subject: mod_substitute tags parsing
Date: Sat, 06 Nov 2010 18:19:33 +0100
From: Nick Gearls <nickgearls@gmail.com>
Reply-To: nickgearls@gmail.com
To: Development Apache <dev@httpd.apache.org>

Hello,

I took the tags parsing code from mod_headers to incorporate it to
mod_substitute.
It almost works, but I cannot obtain the handlers via apr_hash_get() -
even the locally defined ones (%D & %t).
They are all registered:

    static int tags_pre_config(apr_pool_t *p, apr_pool_t *plog,
    apr_pool_t *ptemp)
    {
         format_tag_hash = apr_hash_make(p);
         register_format_tag_handler("D", (const void
    *)tags_request_duration);
         register_format_tag_handler("t", (const void *)tags_request_time);
         register_format_tag_handler("e", (const void
    *)tags_request_env_var);
         register_format_tag_handler("s", (const void
    *)tags_request_ssl_var);

         return OK;
    }


Any idea what could be the problem?

Btw, I copied the code from mod_headers and it is 98% identical, so I'll
modularise it to be 100% portable between these 2 modules (and others).
The next step will be to remove it from the modules itself and make the
static functions global.

Thanks,

Nick