httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Plüm, Rüdiger, VF-Group" <ruediger.pl...@vodafone.com>
Subject RE: SetVirtualDocumentRoot
Date Wed, 10 Nov 2010 16:38:18 GMT
 

> -----Original Message-----
> From: Rich Bowen 
> Sent: Mittwoch, 10. November 2010 17:35
> To: dev@httpd.apache.org
> Subject: Re: SetVirtualDocumentRoot
> 
> 
> On Nov 10, 2010, at 11:26 AM, Plüm, Rüdiger, VF-Group wrote:
> 
> >> -----Original Message-----
> >> From: Rich Bowen
> >> To: dev@httpd.apache.org
> >> Subject: SetVirtualDocumentRoot
> >>
> >> I was reading bug reports this morning, and wondered if
> >> someone could
> >> take a look at the patch offered here:
> >>
> >> https://issues.apache.org/bugzilla/show_bug.cgi?id=26052#c19
> >
> > The patch doesn't look appealing to me. Having a module 
> changing the  
> > core config
> > on the fly always looks nasty to me, even more so if it 
> stores data  
> > in the core config
> > structure that is allocated from a request pool. IMHO this is  
> > waiting for all
> > nasty things to happen, SEGFAULT at best.
> 
> Ok. Fair enough. How about something that set the ENV var for 
> just the  
> current request?
> 
> The frequency with which this gets asked seems to make it worthwhile  
> doing something, even if this patch isn't the right thing to do.

My comment was only about the patch itself. I am yet undecided on the
feature itself, but being +0 currently means I am in nobodys way :-).

Regards

Rüdiger


Mime
View raw message