httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Plüm, Rüdiger, VF-Group" <ruediger.pl...@vodafone.com>
Subject RE: mod_ssl output buffering
Date Fri, 05 Nov 2010 17:17:22 GMT
 

> -----Original Message-----
> From: Joe Orton  
> Sent: Freitag, 5. November 2010 16:22
> To: dev@httpd.apache.org
> Subject: RFC: mod_ssl output buffering
> 
> mod_ssl's output buffering has been bothering me for a while.
> 
> 1) it buffers the encrypted output stream (to some extent) 
> coupled with 
> regular use of FLUSH buckets.  This seems redundant/inefficient; the 
> core output filter should be doing this kind of thing 
> optimally already.
> 
> 2) it does /not/ do any buffering of the plaintext input 
> brigades.  This 
> leads to some pathological inefficiency as discussed here in the past:
> 
> http://marc.info/?l=apache-httpd-dev&m=125070085316400&w=2
> 
> The one justification I know for (1) is in the 
> ssl_engine_io.c comment:
> 
>         /* the first two SSL_writes (of 1024 and 261 bytes)
>          * need to be in the same packet (vec[0].iov_base)
>          */
> 
> but I see no evidence this will not happen if the core output 
> filter is 
> allowed to operate as normal.  Maybe that was not true in the psat.
> 
> So I'd propose to remove (1), which is simple and add (2), 
> which is not 
> so simple.  I've hacked up (yet another) "coalescing" filter for (2) 
> which works to coalesce chunked brigades as expected; proof 
> of concept 
> attached.  Would welcome some discussion before I work on this 
> further...
> 

Sounds reasonable.

Regards

Rüdiger


Mime
View raw message