httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe Jr." <wr...@rowe-clan.net>
Subject Re: initgroups() in mpm_coomon.h
Date Mon, 29 Nov 2010 19:18:09 GMT
On 11/21/2010 11:39 PM, Guenter Knauf wrote:
> Hi,
> in mpm_common.c we have:
> 
> #ifndef HAVE_INITGROUPS
> int initgroups(const char *name, gid_t basegid)
> {
> #if defined(_OSD_POSIX) || defined(OS2) || defined(WIN32) || defined(NETWARE)
>     return 0;
> #else
>[...]


> the only other 2 source files which use initgroups() are mod_unixd.c and suexec.c; with
4
> platforms this function is a dummy; 2 (NetWare and Win32) dont build mod_unix.d.c, and
> OS/2 does #ifndef the part in mod_unixd.c where initgroups() is used - remains only
> _OSD_POSIX which might need the dummy + any other strange Linux which lacks of
> initgroups(); then we have also no conditional prototype for it in any header; and finally
> suexec.c is a standalone program which seems not to be able to use this function unless
> linked with mpm_common.c ...
> so wouldnt it make more sense to either move it into a separare file which can be linked
> to suexec too, or at least to move it into unixd.c or mod_unixd.c ?

And at the very least, namespace protect it too?

Mime
View raw message