httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Fritsch ...@sfritsch.de>
Subject Re: Hook sorting wrong during startup
Date Wed, 03 Nov 2010 20:33:28 GMT
On Wednesday 03 November 2010, Ruediger Pluem wrote:
> > I think apr_hook_sort_all() should be called right after 
> > ap_read_config() before ap_run_pre_config(). Is it really that
> > simple  or am I missing something?
> 
> I guess the question is if we clean up the hook list after
> ap_run_pre_config() and call the modules register_hooks function
> again somewhere in
> 
>         ap_process_config_tree()
>         ap_fixup_virtual_hosts()
>         ap_fini_vhost_config()
> 
> If yes I guess we need to copy the sort call up otherwise a move
> seems to be ok.

AFAICS, there is no way to clean the hook list except by clearing the 
pconf pool, and this is not done in those functions. Therefore it 
should be safe to move the call.

Mime
View raw message