httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r1026668 - /httpd/httpd/trunk/modules/proxy/mod_proxy.h
Date Sat, 23 Oct 2010 19:51:34 GMT
On 10/23/2010 2:34 PM, minfrin@apache.org wrote:
> Author: minfrin
> Date: Sat Oct 23 19:34:16 2010
> New Revision: 1026668
> 
> URL: http://svn.apache.org/viewvc?rev=1026668&view=rev
> Log:
> Optimise more of the flags within proxy structures.

> @@ -325,7 +325,7 @@ struct proxy_worker {
>      apr_port_t      port;
>      char            keepalive;
>      char            disablereuse;
> -    int             is_address_reusable;
> +    int             is_address_reusable:1;
>      proxy_conn_pool     *cp;        /* Connection pool to use */
>      proxy_worker_stat   *s;         /* Shared data */
>      void            *opaque;    /* per scheme worker data */

No; this is a dis-optimization.  You have added int-bitmath cpu cycles
to a simple int test, without gaining any storage.  Huh?

Mime
View raw message