httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Leggett <>
Subject mod_cache: making private headers private
Date Tue, 21 Sep 2010 22:07:15 GMT
Hi all,

mod_cache.h currently contains the following declarations, all of  
which are really private functions that have been accidentally made  
public. I plan to move them to a private header file for this purpose,  
unless any of these declarations need to stay, which in turn means  
they need to be properly namespaced:

  * cache_storage.c
#define MOD_CACHE_REQUEST_REC "mod_cache_request_rec"
int cache_remove_url(cache_request_rec *cache, apr_pool_t *p);
int cache_create_entity(request_rec *r, apr_off_t size,  
apr_bucket_brigade *in);
int cache_select(request_rec *r);
apr_status_t cache_generate_key_default( request_rec *r, apr_pool_t*p,  
char**key );

  * create a key for the cache based on the request record
  * this is the 'default' version, which can be overridden by a  
default function
const char* cache_create_key( request_rec*r );

apr_status_t cache_store_entity_headers(cache_handle_t *h, request_rec  
*r, cache_info *info);
apr_status_t cache_store_entity_body(cache_handle_t *h, request_rec  
*r, apr_bucket_brigade *bb);

apr_status_t cache_recall_entity_headers(cache_handle_t *h,  
request_rec *r);
apr_status_t cache_recall_entity_body(cache_handle_t *h, apr_pool_t  
*p, apr_bucket_brigade *bb);


View raw message