httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jean-frederic clere <jfcl...@gmail.com>
Subject Re: [PATCH] proxy could be quieter about failures while waiting to retry a backend connection
Date Fri, 24 Sep 2010 09:44:47 GMT
On 09/23/2010 05:52 PM, Jeff Trawick wrote:
> Index: modules/proxy/proxy_util.c
> ===================================================================
> --- modules/proxy/proxy_util.c    (revision 999968)
> +++ modules/proxy/proxy_util.c    (working copy)
> @@ -2057,8 +2057,8 @@
>          ap_proxy_retry_worker(proxy_function, worker, s);
>  
>          if (!PROXY_WORKER_IS_USABLE(worker)) {
> -            ap_log_error(APLOG_MARK, APLOG_ERR, 0, s,
> -                         "proxy: %s: disabled connection for (%s)",
> +            ap_log_error(APLOG_MARK, APLOG_INFO, 0, s,
> +                         "proxy: %s: connection disabled for (%s)",
>                           proxy_function, worker->hostname);
>              return HTTP_SERVICE_UNAVAILABLE;
>          }
> 
> What I see is an error log full of "disabled connection for (%s)" after
> a failure is encountered.
> Also, it says "disabled connection" as if it just disabled it, when it
> was disabled at the time of the first failure.
> 
> Concerns?

That should be a DEBUG, no?

Cheers

Jean-Frederic


Mime
View raw message