Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: domain of justin.erenkrantz@gmail.com
 designates 209.85.213.173 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:content-type;
        b=b71Dxd6ld1Vgdy3cK+yzz5yiMUbfoOKM+50EvJ1dU5Ybuo11LmDcWBBxqng0ejLthq
         qjXKkQbz05Ixt/wl2X8H3oDZklgvZZXvw/sryWtQcalcWyTBdav0b0qorFgGNgZWCgIO
         gPTgSy+6DUMMf2zwW7EkGqhQgWKjU60Jr7TmI=
MIME-Version: 1.0
Sender: justin.erenkrantz@gmail.com
In-Reply-To: <4C756BAF.4070706@apache.org>
References: <AANLkTimgGp7znK0JG8WpPe0WOUzZv+XJH8PWK47eQxDR@mail.gmail.com>
	<99EA83DCDE961346AFA9B5EC33FEC08B0489A644@VF-MBX11.internal.vodafone.com>
	<AANLkTin-WdJvn1bFt7pxoEjESzyOLoW7CAS707v+-nfh@mail.gmail.com>
	<4C755992.3090702@rowe-clan.net>
	<4C756BAF.4070706@apache.org>
Date: Wed, 25 Aug 2010 12:20:15 -0700
Message-ID: <AANLkTindmP_9jH-0NWV8r=g4osZvY==iY70N8t=2vZaS@mail.gmail.com>
Subject: Re: httpd trunk broken with Subversion: ap_log_rerror busted
From: Justin Erenkrantz <justin@erenkrantz.com>
To: dev@httpd.apache.org
Content-Type: text/plain; charset=ISO-8859-1

On Wed, Aug 25, 2010 at 12:14 PM, Ruediger Pluem <rpluem@apache.org> wrote:
> I guess his comment was more about the macro wrappers and the C99 stuff,
> which saves us the function call if we would not log due to the loglevel
> currently set. I think this is one aspect of the changes and one were
> we might lack a prove that it really improves performance.

Exactly.

We changed the prototype for ap_log_rerror and friends, but made it so
that it is near-impenetrable to know what changed.  The #ifdef DOXYGEN
approach I outlined earlier would go a way to make it easier for
humans to clearly understand what the altered API is intended to be.
-- justin