httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Covener <cove...@gmail.com>
Subject Fwd: DO NOT REPLY [Bug 49809] DirectoryMatch treats $ as literal instead of EOL
Date Mon, 23 Aug 2010 15:31:24 GMT
How do people feel about a 2.3-only change to:

* drop the NOTEOL flag in the regexec call
* update the doc to drop the idea that DirectoryMatch applies to
"subdirectories" that match the expression.

The manual already uses DirectoryMatch with $-as-EOL in a few places
expecting it behaves this way.  Since it's so simple to make a regex
apply to subdirectories, I don't think the directive needs to be
hamstrung with the NOTEOL flag.


---------- Forwarded message ----------
From:  <bugzilla@apache.org>
Date: Mon, Aug 23, 2010 at 11:28 AM
Subject: DO NOT REPLY [Bug 49809] DirectoryMatch treats $ as literal
instead of EOL
To: bugs@httpd.apache.org


https://issues.apache.org/bugzilla/show_bug.cgi?id=49809

--- Comment #2 from Eric Covener <covener@gmail.com> 2010-08-23 11:28:08 EDT ---
I may actually understand this now. The operative part of the documentation is
this "and sub-directories" part:

<DirectoryMatch> and </DirectoryMatch> are used to enclose a group of
directives which will apply only to the named directory and sub-directories of
that directory, the same as <Directory>. However, it takes as an argument a
regular expression. For example:

Which is why the $ cannot be matched, since we tell PCRE the string we pass in
is not really a string with an end-of-line in it. This is a side of efffect of
expecting it to match sub-directories as well.

Still seems sensless, as with a reasonable default behavior one can just
include subdirectories with the regex itself.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org




-- 
Eric Covener
covener@gmail.com

Mime
View raw message