httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: svn commit: r982050 - in /httpd/httpd/trunk: modules/generators/ modules/slotmem/ modules/ssl/ server/ server/mpm/event/ server/mpm/netware/ server/mpm/prefork/
Date Wed, 04 Aug 2010 12:17:46 GMT
On Tue, Aug 3, 2010 at 6:12 PM,  <sf@apache.org> wrote:
> Author: sf
> Date: Tue Aug  3 22:12:19 2010
> New Revision: 982050
>
> URL: http://svn.apache.org/viewvc?rev=982050&view=rev
> Log:
> remove more unused variables
> revove some obsolete comments
>
> netware file is untested

why remove AP_DEBUG_ASSERT(0)?

>
> Modified:
>    httpd/httpd/trunk/modules/generators/mod_cgid.c
>    httpd/httpd/trunk/modules/slotmem/mod_slotmem_shm.c
>    httpd/httpd/trunk/modules/ssl/ssl_engine_io.c
>    httpd/httpd/trunk/modules/ssl/ssl_engine_pphrase.c
>    httpd/httpd/trunk/modules/ssl/ssl_engine_rand.c
>    httpd/httpd/trunk/server/mpm/event/event.c
>    httpd/httpd/trunk/server/mpm/event/fdqueue.c
>    httpd/httpd/trunk/server/mpm/netware/mpm_netware.c
>    httpd/httpd/trunk/server/mpm/prefork/prefork.c
>    httpd/httpd/trunk/server/mpm_common.c
>    httpd/httpd/trunk/server/mpm_unix.c
>    httpd/httpd/trunk/server/request.c
>    httpd/httpd/trunk/server/util_ebcdic.c
>

> Modified: httpd/httpd/trunk/server/mpm/event/event.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/mpm/event/event.c?rev=982050&r1=982049&r2=982050&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/server/mpm/event/event.c (original)
> +++ httpd/httpd/trunk/server/mpm/event/event.c Tue Aug  3 22:12:19 2010
> @@ -1155,7 +1155,6 @@ static void * APR_THREAD_FUNC listener_t
>                                  ap_server_conf,
>                                  "event_loop: unexpected state %d",
>                                  cs->state);
> -                    AP_DEBUG_ASSERT(0);
>                 }
>
>                 apr_thread_mutex_lock(timeout_mutex);
>
> Modified: httpd/httpd/trunk/server/mpm/event/fdqueue.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/mpm/event/fdqueue.c?rev=982050&r1=982049&r2=982050&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/server/mpm/event/fdqueue.c (original)
> +++ httpd/httpd/trunk/server/mpm/event/fdqueue.c Tue Aug  3 22:12:19 2010
> @@ -165,7 +165,6 @@ apr_status_t ap_queue_info_wait_for_idle
>                                       queue_info->idlers_mutex);
>             if (rv != APR_SUCCESS) {
>                 apr_status_t rv2;
> -                AP_DEBUG_ASSERT(0);
>                 rv2 = apr_thread_mutex_unlock(queue_info->idlers_mutex);
>                 if (rv2 != APR_SUCCESS) {
>                     return rv2;
>

Mime
View raw message