httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r983116 - /httpd/httpd/trunk/modules/filters/mod_reqtimeout.c
Date Sun, 08 Aug 2010 18:19:44 GMT


On 08/06/2010 10:07 PM, pgollucci@apache.org wrote:
> Author: pgollucci
> Date: Fri Aug  6 20:07:57 2010
> New Revision: 983116
> 
> URL: http://svn.apache.org/viewvc?rev=983116&view=rev
> Log:
> rv is never used which makes the whole if useless
> 
> Reported by:	clang static analyzer
> 
> 
> Modified:
>     httpd/httpd/trunk/modules/filters/mod_reqtimeout.c
> 
> Modified: httpd/httpd/trunk/modules/filters/mod_reqtimeout.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/mod_reqtimeout.c?rev=983116&r1=983115&r2=983116&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/filters/mod_reqtimeout.c (original)
> +++ httpd/httpd/trunk/modules/filters/mod_reqtimeout.c Fri Aug  6 20:07:57 2010
> @@ -190,10 +190,7 @@ static apr_status_t reqtimeout_filter(ap
>  #endif
>  
>              rv = ap_get_brigade(f->next, bb, AP_MODE_GETLINE, APR_NONBLOCK_READ,
remaining);
> -            if (APR_STATUS_IS_EAGAIN(rv)) {
> -                rv = APR_SUCCESS;
> -            }
> -            else if (rv != APR_SUCCESS) {
> +            if (rv != APR_SUCCESS) {
>                  break;
>              }

IMHO this is a change in logic. If ap_get_brigade returns EAGAIN then
the old code stays in the loop, whereas the new code leaves the loop.

Regards

RĂ¼diger


Mime
View raw message