httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: svn commit: r986333 - /httpd/httpd/trunk/modules/proxy/mod_proxy_http.c
Date Wed, 18 Aug 2010 14:22:52 GMT

On Aug 18, 2010, at 8:26 AM, Joe Orton wrote:

> On Tue, Aug 17, 2010 at 06:00:58PM +0200, "Plüm, Rüdiger, VF-Group" wrote:
>> I think you should use
>> 
>> && ((apr_table_get(r->headers_in, "Content-Length") || 
>> apr_table_get(r->headers_in, "Transfer-Encoding")))
>> 
>> as we only want do_100_continue to be true *if* we have a request body,
>> which means that either Content-Length or Transfer-Encoding is set
>> in the request. *If* both are unset then we have no request body and
>> hence do_100_continue should be false.
> 
> This needs to check that C-L is non-zero if it is present; sending 
> 100-continue with C-L: 0 will break.
> 

Agreed... In fact, I think I'll create a small util function
that abstracts out whether a request has a body or not... we
do this test all over the place, with various versions of
the logic. Would be nice to standardize that, I think.


Mime
View raw message