Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 14034 invoked from network); 16 Jul 2010 11:48:40 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 16 Jul 2010 11:48:40 -0000 Received: (qmail 30630 invoked by uid 500); 16 Jul 2010 11:48:40 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 30231 invoked by uid 500); 16 Jul 2010 11:48:36 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 30223 invoked by uid 99); 16 Jul 2010 11:48:35 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Jul 2010 11:48:35 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of trawick@gmail.com designates 74.125.83.45 as permitted sender) Received: from [74.125.83.45] (HELO mail-gw0-f45.google.com) (74.125.83.45) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Jul 2010 11:48:28 +0000 Received: by gwj21 with SMTP id 21so1264566gwj.18 for ; Fri, 16 Jul 2010 04:47:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=jrp+3SH8jdPMiv1eP2uk/UIAECINxrAGc+azCHET8/0=; b=YV34ZVa40Wew6N231VFGoxQkFu8gjLC24aboUlfMVCUVcH4IqFiRfEWA9Bgt0L2Lpq uGC76PkQkeGPnt4U/n7mq/0hmbtotvxNf8/rL9knD7ONqR1/VUB9DMB3nt9nwgpGOeYN Z4gQGbBUpYIhfM3I9zs7HZOA39PpcaKSAcotA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=FPh0KrA4/zdHsDARREHyhFGEYMMchZ4K22a/7VKx7wwp0XBNRo01pxFLAd1eaXmlw5 j8T7P9iHdzIb7gUCYsxnv5d4hk4mNuxxh1stNmZAc9ECmm/8tDPgIxAJaxiVhlYqRNiS V5WQsWW2daxPEvzhdKEGVtoVmthJcieuDegVU= MIME-Version: 1.0 Received: by 10.101.144.11 with SMTP id w11mr1060382ann.236.1279280827663; Fri, 16 Jul 2010 04:47:07 -0700 (PDT) Received: by 10.100.239.7 with HTTP; Fri, 16 Jul 2010 04:47:07 -0700 (PDT) In-Reply-To: <4C3FA975.7070901@primary.net> References: <20100401224838.ED01823889B3@eris.apache.org> <1BAC29AE-3A12-48D4-BA3E-DFBEDE83653F@jaguNET.com> <4C3FA975.7070901@primary.net> Date: Fri, 16 Jul 2010 07:47:07 -0400 Message-ID: Subject: Re: svn commit: r930125 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h modules/proxy/mod_proxy_balancer.c From: Jeff Trawick To: dev@httpd.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org On Thu, Jul 15, 2010 at 8:36 PM, Daniel Ruggeri wrot= e: > On 7/12/2010 2:17 PM, Jim Jagielski wrote: >> >> On Jul 11, 2010, at 11:04 AM, Jeff Trawick wrote: >> >> >>> >>> On Thu, Apr 1, 2010 at 6:48 PM, =A0wrote: >>> >>>> >>>> Author: niq >>>> Date: Thu Apr =A01 22:48:38 2010 >>>> New Revision: 930125 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=3D930125&view=3Drev >>>> Log: >>>> Proxy balancer: support setting error status according to >>>> HTTP response code from a backend. >>>> PR 48939 [Daniel Ruggeri] >>>> >>> >>> >>>> >>>> + =A0 =A0else if (!strcasecmp(key, "erroronstatus")) { >>>> >>> >>> Any opinions on "erroronstatus"? =A0It doesn't feel quite right to me, >>> but I'm not confident about a replacement. >>> >>> Just plain "errorstatus" or "errorstatuscodes"? >>> >>> If normal response handling takes the same action on other status >>> codes (I dunno), maybe "extraerrorstatus" or "extraerrorstatuscodes" >>> would be bettter? >>> >>> >> >> proxyseterror? >> >> >> > > If erroronstatus is right out, I like errorstatuscodes best as a > replacement. > > Jeff; > =A0 I will gladly take the tasks you mentioned in STATUS as soon as we ha= ve > consensus on the name of the directive. It may be a lofty goal but it wou= ld > be great if this could make it into 2.2.16. We may as well leave it at "erroronstatus" I agree with Eric on keeping your original choice and worrying about the doc.