httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Ruggeri <DRugg...@primary.net>
Subject Re: svn commit: r930125 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h modules/proxy/mod_proxy_balancer.c
Date Tue, 20 Jul 2010 14:59:04 GMT
On 7/16/2010 10:37 AM, Jeff Trawick wrote:
> On Fri, Jul 16, 2010 at 11:27 AM, William A. Rowe Jr.
> <wrowe@rowe-clan.net>  wrote:
>    
>> On 7/16/2010 9:35 AM, William A. Rowe Jr. wrote:
>>      
>>> On 7/16/2010 6:47 AM, Jeff Trawick wrote:
>>>        
>>>> We may as well leave it at "erroronstatus"  I agree with Eric on
>>>> keeping your original choice and worrying about the doc.
>>>>          
>>> Can we drop the word error, since it has four potential meanings?
>>>
>>> backendfailureonstatus perhaps, or something along those lines?
>>>        
>> Hold up; see http://tomcat.apache.org/connectors-doc/reference/workers.html
>> fail_on_status - why would we invent new phrases?
>>      
> good catch
>
>
>    
Sounds like this would be the best name. As promised, here is the final 
patch including doc, the name "failonstatus", and updates made in trunk 
for this patch. Also included is an update to trunk for the new name and 
doc.

For ease of reading, the doc patch reads thusly:
         A single or comma-separated list of HTTP status codes. If set 
this will
         force the worker into error state when the backend returns any 
status code
         in the list. Worker recovery behaves the same as other worker 
errors.

Finally, here is my proposed change to STATUS to indicate completion of 
Jeff's suggestions as well as update the location of the 2.2.x patch:
--- STATUS      2010-07-20 09:53:36.298789200 -0500
+++ STATUS.mod  2010-07-20 09:54:15.466286400 -0500
@@ -145,13 +145,9 @@
      statuses are found
      PR: 48939
      Trunk patch: http://svn.apache.org/viewvc?rev=930125&view=rev
-    2.2.x patch: https://issues.apache.org/bugzilla/attachment.cgi?id=25153
+    2.2.x patch: https://issues.apache.org/bugzilla/attachment.cgi?id=25788
      Submitted by: Daniel Ruggeri <DRuggeri primary.net>
      +1: niq, jim
-    trawick suggests:
-      1. somebody write doc (Daniel volunteers)
-      2. somebody create new patch which includes r962972, any
-          subsequent changes, and doc (Daniel volunteers)

    * mod_disk_cache: Decline the opportunity to cache if the response is
      a 206 Partial Content. This stops a reverse proxied partial response


Thank you, all.
--
Daniel Ruggeri

Mime
View raw message