httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Plüm, Rüdiger, VF-Group" <ruediger.pl...@vodafone.com>
Subject RE: httpd-trunk - NetWare build - observations.
Date Thu, 24 Jun 2010 10:56:15 GMT
 

> -----Original Message-----
> From: Jeff Trawick 
> Sent: Donnerstag, 24. Juni 2010 12:41
> To: dev@httpd.apache.org
> Subject: Re: httpd-trunk - NetWare build - observations.
> 
> On Wed, Jun 23, 2010 at 11:08 PM, William A. Rowe Jr.
> <wrowe@rowe-clan.net> wrote:
> > On 6/23/2010 6:27 PM, Nick Kew wrote:
> >>
> >> On 23 Jun 2010, at 23:50, NormW wrote:
> >>

> >>>> --- mod_authn_socache.c.orig        2010-06-24 
> 06:47:46.796875000 +1000
> >>>> +++ mod_authn_socache.c     2010-06-24 07:11:34.546875000 +1000
> >>>> @@ -301,11 +301,12 @@
> >>>>      * to no-longer-defined memory.  Hmmm ...
> >>>>      */
> >>>>     apr_status_t rv;
> >>>> +    const char *key;
> >>>>     unsigned char val[MAX_VAL_LEN];
> >>>>     unsigned int vallen = MAX_VAL_LEN - 1;
> >>>>     authn_cache_dircfg *dcfg = 
> ap_get_module_config(r->per_dir_config,
> >>>>                                              
      
> &authn_socache_module);
> >>>> -    const char *key = construct_key(r, dcfg->context, 
> user, NULL);
> >>>> +    key = construct_key(r, dcfg->context, user, NULL);
> >>>>     rv = socache_provider->retrieve(socache_instance, r->server,
> >>>>                                     (unsigned char*)key,

> strlen(key),
> >>>>                                     val, &vallen,
r->pool);
> >>
> >> Huh?  Sounds like a bug in your compiler!  What's the 
> problem with the trunk code?
> >
> > Huh?  Sounds like C++ fixation!  Whats with the C99 attitude issues?
> >
> > Please, this is a style violation.  Fix already.
> 
> I could be blind, but I don't see dispersed statements and
> declarations.  It is all decls from "apr_status_t rv" through "const
> char *key = contruct_key()".
> 

Me neither. What is C++ style about the above?

Regards

Rüdiger


Mime
View raw message