httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Plüm, Rüdiger, VF-Group" <ruediger.pl...@vodafone.com>
Subject RE: svn commit: r952201 - /httpd/httpd/trunk/server/log.c
Date Tue, 08 Jun 2010 16:24:22 GMT
 

> -----Original Message-----
> From: Rainer Jung 
> Sent: Dienstag, 8. Juni 2010 18:19
> To: dev@httpd.apache.org
> Subject: Re: svn commit: r952201 - /httpd/httpd/trunk/server/log.c
> 

> >
> > How about a local static variable in the function?
> 
> I tried it. But:
> 
> you can actually switch between MPMs now by apachectl graceful or 
> restart when building them dynamically. The static in the 
> children comes 
> via fork from the parent process. The naive way of initializing it to 
> UNSET and then setting it once to the result of the MPM query doesn't 
> work, because it will miss any changes due to restart.

Good point. I missed that a graceful restart now can change the MPM.

> If we keep the variable local in the log function, then it 
> would have to 
> check whenever it logs whether a restart has happened. I 
> assume querying 
> the MPM isn't more expensive.

Agreed.

Regards

Rüdiger


Mime
View raw message